Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to build Docker image on tags #352

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

fpotier
Copy link
Member

@fpotier fpotier commented Aug 20, 2024

Description

Push a new Docker image when a tag is created

Copy link
Contributor

@bpedersen2 bpedersen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpotier
Copy link
Member Author

fpotier commented Aug 20, 2024

@bpedersen2 I think it would be a good idea to release a new version with the all the package upgrades and I also think that a relatively recent patch made the container configurable at runtime

@bpedersen2 bpedersen2 merged commit 978eb53 into develop Aug 20, 2024
7 checks passed
@bpedersen2 bpedersen2 deleted the ci-release branch August 20, 2024 08:53
@bpedersen2
Copy link
Contributor

Yes, definetly.

But build fails ;)

/usr/bin/docker buildx build --iidfile /home/runner/work/_temp/docker-actions-toolkit-wuehXQ/build-iidfile-00b18d9961.txt --platform linux/amd64,linux/arm64/v8 --tag ghcr.io/scicatproject/landingpageserver:v3.2-rc1 --tag ghcr.io/scicatproject/landingpageserver:stable --metadata-file /home/runner/work/_temp/docker-actions-toolkit-wuehXQ/build-metadata-7694e5a423.json --push .
ERROR: Multi-platform build is not supported for the docker driver.
Switch to a different driver, or turn on the containerd image store, and try again.
Learn more at https://docs.docker.com/go/build-multi-platform/

@fpotier
Copy link
Member Author

fpotier commented Aug 20, 2024

Ah I copied this workflow but it looks like it never actually ran.

@fpotier fpotier restored the ci-release branch August 20, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants