Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start using DifferentiationInterface #218

Open
avik-pal opened this issue Oct 5, 2024 · 5 comments · May be fixed by #258
Open

Start using DifferentiationInterface #218

avik-pal opened this issue Oct 5, 2024 · 5 comments · May be fixed by #258
Assignees
@ErikQQY

Comments

@avik-pal
Copy link
Member

avik-pal commented Oct 5, 2024

Opening an issue to track what all is needed. With Constant being a thing now, this should be relatively straight-forward. Also NonlinearSolve update is done and released so this should unify the ecosystem.

Another thing I want to do it figure out if we can use an existing ADType and ditch the BVPJacobianAlgorithm or is that needed? My guess would be the latter because we want fine-grained control over how to deal with each part of the jacobian.
@ChrisRackauckas
Copy link
Member

Resizing is the difficult part though. Every time the time steps adapt, the cache will need to be resized.

@gdalle
Copy link

gdalle commented Oct 14, 2024

Resizing is the difficult part though. Every time the time steps adapt, the cache will need to be resized.

To start experimenting with this, I introduced a secret function in JuliaDiff/DifferentiationInterface.jl#521 with the right semantics. Right now it re-creates a cache from scratch every time, but we can optimize it for some backends and operators

@ErikQQY ErikQQY self-assigned this Nov 19, 2024
@ErikQQY
Copy link
Member

ErikQQY commented Nov 19, 2024 •
edited
Loading

Working on this, and have a functional implementation, will PR soon

@gdalle
Copy link

gdalle commented Nov 19, 2024

Amazing! I'm around to help out if needed

@gdalle
Copy link

gdalle commented Nov 19, 2024

Did you encounter any major hurdles? Did it lead to at least some amount of code simplification?

@ErikQQY ErikQQY linked a pull request Nov 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ErikQQY ErikQQY

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use DifferentiationInterface for the jacobian ErikQQY/BoundaryValueDiffEq.jl
4 participants
@ChrisRackauckas @gdalle @avik-pal @ErikQQY