-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support of complex numbers for mesh adaptivity in MIRK method #259
base: master
Are you sure you want to change the base?
Conversation
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
@JulianUlrich Thank you for your contribution! Under what circumstances do you want to use this? |
I got an error from adaptivity when having complex states in the model. This can be useful in electrical engineering. F.e. for evaluating the impedance of a transmission line model. Mostly, only the boundary values are needed as a result, so it makes sense to start with a coarse mesh. |
Yeah, I can understand using complex states when we have impedances in the circuit, but I suspect the current implementation can support such models, can you please share an MWE or some simple models that can illustrate the basic idea, there may be more things to do to support these cases. |
Here's a simple code for testing:
This could be a Transmission line with space-dependent conductivity...
|
Yeah, the main issue here is the adaptivity routines, could you please add this as a test case and also add the changes to the FIRK methods adaptivity as well? |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Complex states seemed not to be compatible with mesh adaptivity. I just took the magnitude of the values in cache instead of their complex representation. Maybe not the best way, but it works...