Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not always report maxiters #14

Open
ChrisRackauckas opened this issue Jan 17, 2017 · 1 comment
Open

Does not always report maxiters #14

ChrisRackauckas opened this issue Jan 17, 2017 · 1 comment

Comments

@ChrisRackauckas
Copy link
Member

The ODE and SDE solvers halt and throw a warning when maxiters is reached. After that, we check:

length(sol)>= .9*maxiters

to see if maxiters is reached, and throw an error. This is very inexact though, since length(sol)<=maxiters since it's only the accepted timesteps, and so if more than 10% of the timesteps were rejected, this will not throw the error. Somehow we need to catch the warning?

@ChrisRackauckas
Copy link
Member Author

This can be fixed by using the retcode part of the solution type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant