Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump download/upload artifact gha version #396

Closed
wants to merge 1 commit into from
Closed

Bump download/upload artifact gha version #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci-locks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ jobs:
tox -e ${{ matrix.lock }} -- --platform osx-64 --platform win-64

- name: "Upload lock artifacts"
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: lock-artifacts
path: ${{ github.workspace }}/requirements/locks/${{ matrix.lock }}*.txt
Expand All @@ -107,7 +107,7 @@ jobs:
uses: actions/checkout@v4

- name: "Download lock artifacts"
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: lock-artifacts
path: ${{ github.workspace }}/requirements/locks
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/ci-wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
UDUNITS2_XML_PATH: ${{ matrix.xml_path }}
CIBW_ENVIRONMENT_PASS_LINUX: UDUNITS2_INCDIR UDUNITS2_LIBDIR UDUNITS2_XML_PATH

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: pypi-artifacts
Copy link
Member

@pp-mo pp-mo Dec 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we've seen the basic v3-to-v4 changes is that artifacts are now immutable and non-rewritable

So I think the problem here is probably that the artifact name must be different for each usage,
so, something like pypi-artifacts-${{ matrix.os }}-${{ matrix.arch }} might work ?

It seems like that, now we are storing different ones in different places, the other tasks will also probably need updating? TBH I'm a bit out of my depth with this.

Copy link
Member Author

@bjlittle bjlittle Dec 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, there is now no artifact merging and names have to be unique

path: ${{ github.workspace }}/wheelhouse/*.whl
Expand All @@ -91,7 +91,7 @@ jobs:
run: |
pipx run build --sdist

- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: pypi-artifacts
path: ${{ github.workspace }}/dist/*.tar.gz
Expand All @@ -102,7 +102,7 @@ jobs:
name: "Show artifacts"
runs-on: ubuntu-latest
steps:
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: pypi-artifacts
path: ${{ github.workspace }}/dist
Expand All @@ -119,7 +119,7 @@ jobs:
# upload to Test PyPI for every commit on main branch
if: github.event_name == 'push' && github.event.ref == 'refs/heads/main'
steps:
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: pypi-artifacts
path: ${{ github.workspace }}/dist
Expand All @@ -140,7 +140,7 @@ jobs:
# upload to PyPI for every tag starting with 'v'
if: github.event_name == 'push' && startsWith(github.event.ref, 'refs/tags/v')
steps:
- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: pypi-artifacts
path: ${{ github.workspace }}/dist
Expand Down
Loading