Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repo-review #456

Merged
merged 5 commits into from
Sep 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# See https://pre-commit.com for more information
# See https://pre-commit.com/hooks.html for more hooks
# See https://github.com/scientific-python/cookie#sp-repo-review for repo-review

repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
Expand Down Expand Up @@ -44,3 +45,10 @@ repos:
hooks:
- id: sort-all
types: [file, python]

- repo: https://github.com/scientific-python/cookie
rev: 2024.08.19
hooks:
- id: sp-repo-review
additional_dependencies: ["repo-review[cli]"] # TODO: Only neededed if extra dependencies are required
#args: ["--show=errskip"] # show everything for the moment
23 changes: 23 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -73,3 +73,26 @@ line_length = 79
profile = "black"
skip_gitignore = "True"
verbose = "False"

[tool.repo-review]
# These are a list of the currently failing tests:
ukmo-ccbunney marked this conversation as resolved.
Show resolved Hide resolved
ignore = [
"PY005", # Has tests folder
"PP003", # Does not list wheel as a build-dep
"PP304", # Sets the log level in pytest
"PP305", # Specifies xfail_strict
"PP306", # Specifies strict config
"PP307", # Specifies strict markers
"PP309", # Filter warnings specified
"GH104", # Use unique names for upload-artifact
"GH212", # Require GHA update grouping
"PC110", # Uses black or ruff-format
"PC140", # Uses a type checker
"PC160", # Uses a spell checker
"PC170", # Uses PyGrep hooks (only needed if rST present)
"PC180", # Uses a markdown formatter
"PC190", # Uses Ruff
"PC901", # Custom pre-commit CI message
"MY100", # Uses MyPy (pyproject config)
"RF001", # Uses RUFF
]
Loading