Merge pull request #62 from HarmenM/master

Ignore default Twitter logo
ScientaNL · Apr 19, 2019 · 1c84932 · 1c84932
2 parents 90b7496 + 1bc8b37
commit 1c84932
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/app/lib/extractors/AbstractStrategy.js b/app/lib/extractors/AbstractStrategy.js
@@ -44,7 +44,7 @@ class AbstractStrategy
 			const response = await fetch(src);
 
 			result.buffer = await response.buffer();
-			result.origin = src;
+			result.origin = response.url || src;
 		}
 
 		const imageInfo = imageType(result.buffer);

diff --git a/app/lib/extractors/twitter-logo/TwitterLogoStrategy.js b/app/lib/extractors/twitter-logo/TwitterLogoStrategy.js
@@ -35,7 +35,8 @@ class TwitterLogoStrategy extends AbstractStrategy
 				result.weight
 			);
 
-			if(definition) {
+			// Twitter logo can also resolve to default profile logo, ignore the egg ;-) (Which is not an egg anymore)
+			if(definition && definition.origin.indexOf("default_profile") === -1) {
 				images.push((definition));
 			}
 		}