Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example pre-commit based on this projects own pre-commit-config #269

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ddxv
Copy link

@ddxv ddxv commented Jan 17, 2024

New to Godot and Gdscript but was excited to find a formatter/linter. Reading the README I thought it wouldn't work with pre-commit but tried anyways with the pre-commit-config.yaml in the project, was happy to see that it did.

If using this with pre-commit is an expected use case then I think it would good to have this in the README for new users.

@Scony
Copy link
Owner

Scony commented Jan 19, 2024

Looks like a good idea. I'll give it a try in the upcoming days and merge it in case it works smoothly. Thanks for raising this.

@ddxv
Copy link
Author

ddxv commented Jan 20, 2024

Thanks. I've been using it for a couple days in my pre-commit and it's working as expected. Are there any CLI extras or modifiers you might want to include in the example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants