-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gdformat config file for excluding folders. #286
Add gdformat config file for excluding folders. #286
Conversation
Looks promising. I've been thinking about the config file for a while and IMO using What do you think? |
The benefits of a config file that come to mind are
Basically a formatting tool operates similarly to a linting tool, in that I hope that other developers and myself can easily use it frequently without much fuss. Also Godot has the added situation of expecting us to commit "addons" into the repo in the Finally, if all we intend to do is add a command line argument, at last in Linux, this is pretty easily done already: But it is nice that running gdlint is so much simpler: and with a config file gdformat can also be just: Prettier has a config file to ignore files: https://prettier.io/docs/en/ignore.html Those are my thoughts anyway and why I was wanting a config file for gdformat, a tool that I really love and hope to see become a standard for GDScript. |
a68c57c
to
ab3fed7
Compare
Ok, that makes sense. Let's just rename to |
023173a
to
e0047f4
Compare
Updated code is ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
This is an initial stab at fixing Issue #250
Some decisions I made that could go differently:
This is sort of an "easiest possible path" solution. Feel free to suggest better alternatives, but this appears to work for me.