Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore (GitHub API): Use repo ID, instead of repo name #12093

Conversation

brian6932
Copy link
Contributor

@brian6932 brian6932 commented Oct 25, 2023

Repo names are subject to change, IDs aren't

Relates to ScoopInstaller/Main#5215 ScoopInstaller/Versions#1429

@github-actions

This comment was marked as outdated.

@brian6932 brian6932 marked this pull request as draft October 25, 2023 01:27
@brian6932 brian6932 marked this pull request as ready for review October 25, 2023 01:57
@github-actions

This comment was marked as outdated.

@brian6932
Copy link
Contributor Author

/verify

@github-actions
Copy link
Contributor

Your changes do not pass checks.

86box

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

age

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

bitwarden

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

bloop

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

chromium

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

clingo

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

debugviewpp

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

dismplusplus

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

dosbox-x

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

fancontrol

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

fmedia

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

freecad

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

garbro

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

ghidra

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

gitextensions

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

github

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

icecast

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

ilspy

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

inkscape-extension-sozi

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

insomnia

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

jexiftoolgui

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

lightbulb

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

linkerd

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

liteide

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

magicavoxel

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

mindforger

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

mpv.net

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

nekoray

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

neovim-qt

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

notesnook

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

nuclear

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

onlyoffice-desktopeditors

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

prusaslicer

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

puttie

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

redasm

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

regiontoshare

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

rssguard

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

saber

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

scoop-completion

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

scratch

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

so

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

soundswitch

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

spicetify-themes

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

standardnotes

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

status

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

streamlabs-obs

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

stremio

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

subsync

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

switchhosts

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

thonny

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

tlaplus-toolbox

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

todolist

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

total-registry

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

ubports-installer

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

uniextract2

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

universal-android-debloater

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

youtube-dl-gui

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

zeronet

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@brian6932
Copy link
Contributor Author

I'm unsure why debugviewpp fails /verify, it works perfectly fine when setting version to 0, and running bin\checkver.ps1 -u on it

@rashil2000
Copy link
Member

I'm unsure why debugviewpp fails /verify, it works perfectly fine when setting version to 0, and running bin\checkver.ps1 -u on it

Let's debug that in a separate PR

@brian6932 brian6932 force-pushed the chore/use-gh-repo-id-when-api-is-used branch from a5eb772 to 660310c Compare October 26, 2023 10:47
@rashil2000 rashil2000 merged commit 70aed60 into ScoopInstaller:master Oct 27, 2023
2 checks passed
@HUMORCE HUMORCE mentioned this pull request Nov 30, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants