Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odin@2024-12: Add extract_dir property to odin and odin-dev #2059

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

chrislavoy
Copy link

Closes #1778

Odin releases currently have a structure of:

odin-windows-amd64-dev-2024-12.zip
| - dist.zip
    | - dist
        | LICENSE
        | base
        | core
        | examples
        | LLVM-C.dll
        | odin.exe
        | shared
        | vendor

Adding the extract_dir property with a value of dist allows Odin to be installed properly.

Copy link
Contributor

github-actions bot commented Dec 9, 2024

All changes look good.

Wait for review from human collaborators.

odin-dev

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

odin

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@adilahmeddev adilahmeddev mentioned this pull request Dec 23, 2024
1 task
Copy link
Contributor

@brian6932 brian6932 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply the same change to ./bucket/odin-nightly.json, and fixes/closes link #1805 & #2083.

diff --git a/bucket/odin-nightly.json b/bucket/odin-nightly.json
index 22fffe96e..08cc4bc52 100644
--- a/bucket/odin-nightly.json
+++ b/bucket/odin-nightly.json
@@ -9,7 +9,7 @@
             "hash": "57fe19c44f428b990d0b7c07388c1fa5fb9d4e06128ed881275969fc177cf0a5"
         }
     },
-    "extract_dir": "windows_artifacts",
+    "extract_dir": "dist",
     "bin": "odin.exe",
     "checkver": {
         "url": "https://odinbinaries.thisdrunkdane.io/file/odin-binaries/nightly.json",

@chrislavoy
Copy link
Author

Applied suggested change. Let me know if there's anything else I need to change.

@brian6932
Copy link
Contributor

fixes/closes link #1805 & #2083.

Edit #2059 (comment) with

closes #1805
closes #2083

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: odin and odin-dev extraction problem
2 participants