Date fix (#47)

* non-default rownames fix

* POSIXlt and POSIXct fix

* rownames test

* spacing change

* increment release

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: RtoSQLServer
 Title: Load R Dataframes into SQL Server Database Tables
-Version: 0.1.4
+Version: 0.1.5
 Authors@R: c(
     person("Tom", "Wilson", email = "thomas.wilson@gov.scot", role = "cre"),
     person("Miles", "Drake", email = "miles.drake@gov.scot", role = "aut"),

R/create_replace_table.R

@@ -462,6 +462,14 @@ nan_to_na <- function(dataframe) {
   dataframe
 }
 
+clean_row_names <- function(dataframe) {
+  if (.row_names_info(dataframe) >= 0) {
+    warning("non-default rownames in input df will not be loaded")
+    rownames(dataframe) <- NULL
+  }
+  dataframe
+}
+
 
 #' Write an R dataframe to SQL Server table optionally with system
 #' versioning on.
@@ -520,6 +528,8 @@ write_dataframe_to_db <- function(server,
   dataframe <- clean_column_names(dataframe, table_name)
   # Replace NaN values with NA
   dataframe <- nan_to_na(dataframe)
+  # Check for and remove rownames
+  dataframe <- clean_row_names(dataframe)
   # Create staging table
   create_staging_table(db_params, dataframe)
   # Check if target table already exists

R/utils.R

@@ -60,7 +60,7 @@ df_to_metadata <- function(dataframe) {
 
 
 r_to_sql_data_type <- function(col_v) {
-  r_data_type <- class(col_v)
+  r_data_type <- class(col_v)[1]
   if (r_data_type %in% c("character", "factor")) {
     col_v <- as.character(col_v) # to ensure factor cols are character
     max_string <- max(nchar(col_v), na.rm = TRUE)

tests/testthat/test-create_replace_table.R

@@ -126,3 +126,7 @@ test_that("insert sql created correctly", {
 
   expect_identical(args[[1]][[3]], check_sql)
 })
+
+test_that("non-default rownames removed", {
+  expect_warning(clean_row_names(mtcars))
+})