-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add all timing edge cases #158
Merged
GhostOf0days
merged 7 commits into
ScottyLabs:main
from
cirex-web:tests/all-timing-edge-cases
Sep 22, 2024
Merged
tests: add all timing edge cases #158
GhostOf0days
merged 7 commits into
ScottyLabs:main
from
cirex-web:tests/all-timing-edge-cases
Sep 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
GhostOf0days
approved these changes
Sep 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no issues. Thanks for your PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds everything mentioned in https://github.com/ScottyLabs/dining-api/wiki/Timing-Cases.
This does not pass with the code as-is, but should probably be merged before the refactor PR
I mocked out the Axios GET endpoint and replaced it with partly dynamically generated HTML files meant to simulate the real dining pages. A lot of this has been abstracted away (see
mockAxios.ts
andmockTimings.ts
) with the goal of cleaner tests like the following:With these added tests, we can be more confident that future code changes won't break existing parsing functionality.
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: