#35 singular product page icon section #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 2, 2021 13:19
…ion is still needed for styling mobile version of this section.
josephmannis
requested changes
Apr 17, 2021
| height: 56px; | ||
| margin-right: 18px; | ||
| margin-top: 44px; | ||
| background-color: #C4C4C4; |
There was a problem hiding this comment.
Can you make this color a variable please?
| font-size: calc(50px + (50 - 32) * ((100vw - 300px) / (1440 - 300))); | ||
| padding-top: 27px; | ||
|
|
||
| @media (max-width: ${dimensions.maxwidthTablet}px) { |
There was a problem hiding this comment.
Can you remove this empty query please
| <IconContainer> | ||
| {data.icons.map(icon => { | ||
| return ( | ||
| <Icon> |
There was a problem hiding this comment.
Can you please make sure these have a unique key
| return ( | ||
| <Icon> | ||
| <IconImage> | ||
| <img src={icon.icon_image.url} alt="Icon"/> |
There was a problem hiding this comment.
Can you have the alt text come from the CMS please?
| <ImageContainer> | ||
| <MainImage></MainImage> | ||
| <SmallImageContainer> | ||
| <SmallImage></SmallImage> |
There was a problem hiding this comment.
What are these empty things for?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.