Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a DBus message handler that plays a video via Qt #1931

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

nicomiguelino
Copy link
Contributor

@nicomiguelino nicomiguelino commented Jun 14, 2024

Description

  • Qt (via QMediaPlayer) will replace VLC for playing videos.
  • This might fix the black gap between active video assets.
    • Replacing OMX with VLC doesn't cut it, so I decided to resort to using Qt's media player.
  • The changes might not work on older Pi devices. With that, the replacement will only be partial.

Related Issues

Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@nicomiguelino nicomiguelino mentioned this pull request Jun 14, 2024
4 tasks
@nicomiguelino nicomiguelino marked this pull request as ready for review June 21, 2024 16:34
@nicomiguelino nicomiguelino requested a review from a team as a code owner June 21, 2024 16:34
@vpetersson
Copy link
Contributor

This PR doesn't seem to change the actual playback method tho. It only adds it to QT.

Also, this needs to be tested on Pi 3, Pi 4 and ideally others.

@nicomiguelino nicomiguelino changed the title Replaces OMXPlayer with Qt (C++) Added a DBus message handler that plays a video via Qt Jun 22, 2024
@nicomiguelino nicomiguelino changed the title Added a DBus message handler that plays a video via Qt Adds a DBus message handler that plays a video via Qt Jun 22, 2024
@nicomiguelino nicomiguelino marked this pull request as draft July 22, 2024 23:00
Copy link

sonarcloud bot commented Jul 24, 2024

Copy link

sonarcloud bot commented Oct 1, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants