Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squeak needs variant implementation of #openDebuggerOn: #1390

Closed
timrowledge opened this issue Nov 5, 2023 · 3 comments
Closed

Squeak needs variant implementation of #openDebuggerOn: #1390

timrowledge opened this issue Nov 5, 2023 · 3 comments

Comments

@timrowledge
Copy link

The vanilla Process>>#debug:title:full: is deprecated in Squeak 6.1.

I propose implementing GRSqueakPlatform>>#openDebuggerOn:
openDebuggerOn: anError
"Squeak variant based on the Pharo platform code, intended to avoid the deprecated #debug:title:full: message"

| process |
process := Processor activeProcess.
"If we are running in the UI process, we don't want to suspend the active process. The
error was presumably triggered while stepping in the Debugger. If we simply immediately
signal an UnhandledError, the debugger will catch this and display the signaling context.
It isn't perfect or pretty but it works."
process == Project uiProcess
	ifTrue: [UnhandledError signalForException: anError ]
	ifFalse: 
		[WorldState addDeferredUIMessage:
			[ToolSet handleError: anError].
		process suspend]
@timrowledge timrowledge changed the title Squeak needs variant implemtentaion of #openDebuggerOn: Squeak needs variant implementation of #openDebuggerOn: Nov 5, 2023
@timrowledge
Copy link
Author

Better, simpler, more resilient version -
Grease-Squeak-debugger.2.txt

@marschall
Copy link
Contributor

Thanks, will be resolved in SeasideSt/Grease#181.

@timrowledge
Copy link
Author

timrowledge commented Jul 16, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants