Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading error message when using citation marks in the REPO_PATH in windows #98

Open
GoogleCodeExporter opened this issue Mar 12, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. go to any directory out of boar on your local disk c:\temp for example
2. type boar ls
3. You get error no repository specified
4. set REPO_PATH="c:\path\to\your\repository"
5. type same command again boar ls
6. you get error: ERROR: The path c:\temp\"c:\path\to\your\repository" 

What is the expected output? What do you see instead?
see above

What platform are you using? (Windows XP, Windows 7, Linux, ...)
Win7 64 bit

What version of Python are you using?
no idea, the one delivered with boar

What version of boar are you using? (Mercurial change id or daily build
date)
Boar version boar.16-Nov-2012


Please provide any additional information below.

Original issue reported on code.google.com by ph...@richard-vanek.eu on 14 Jun 2013 at 11:36

@GoogleCodeExporter
Copy link
Author

Yup, a quite embarrassingly obvious bug. Thanks!

Original comment by ekb...@gmail.com on 22 Jun 2013 at 12:18

  • Changed state: Accepted

@GoogleCodeExporter
Copy link
Author

Wait... Actually, turns out that the "set" command uses the entire string to 
the right of the equal sign, including any citation marks. 

Hence, if you replace 

REPO_PATH="c:\path\to\your\repository"

with

REPO_PATH=c:\path\to\your\repository

then, it works. Windows is weird... So, not really a bug in Boar. Still, 
probably a common mistake in DOS. I'll leave this bug as an open minor, and add 
some kind of helpful error message.

Original comment by ekb...@gmail.com on 22 Jun 2013 at 12:32

  • Changed title: Misleading error message when using citation marks in the REPO_PATH in windows
  • Added labels: Priority-Low
  • Removed labels: Priority-Medium

@GoogleCodeExporter
Copy link
Author

Thank you for looking into it. The reason I use citation marks was that I had 
space in path name to the repository and it felt like correct thing to do. Even 
Command prompt in Win7 does add them automatically.

Strange is that, as you noted yourself, that when setting env. variable using 
set command it take whole string until end of line. This means also all spaces 
in path to repository.

-r-

Original comment by ph...@richard-vanek.eu on 13 Jul 2013 at 9:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant