Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launcher is Not Pulling Correct Release Info #19

Open
mobbyg opened this issue Oct 6, 2023 · 0 comments
Open

Launcher is Not Pulling Correct Release Info #19

mobbyg opened this issue Oct 6, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@mobbyg
Copy link
Collaborator

mobbyg commented Oct 6, 2023

The current version of Launcher, has the ability to grab release notes from GitHub API based on a hard coded setting in the Launcher::handle_releases_reply() method in Launcher.cpp. There appears to be a place holder for a VersionInfo::getAuthVersionNumber(); on line 238, which is not written from what I can see.

Based on the what is hard coded in Launcher for the version number to pull the notes from the GitHub API, the AdminRPC in SEGSAdmin, wasn't completed yet. (See the picture below, as v0.6.0 "Outbreak" was the current release.) AdminRPC was released in v0.7.0 "Awakening", and works pretty well from my tests with some Python code and with the current WebUI version.

Hopefully @miles200 or @broxen may have some free time to take a stab at this? Knock some rust off?

I did change it in my local copy and it works well, but the only bump I see in the road would be the subsequent versions that compromise fixes, as v0.7.9 is what is current for the release number.

My thinking is though, when "Client" is started, we'll switch the API call for the client version, so the player knows if there is an update.
We could also keep the admin version as an extra someplace in Launcher with a button to check that?!

v0.6.0
F5W-BE6XgAA-gen

v0.7.0
image

@mobbyg mobbyg added the enhancement New feature or request label Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant