Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed version tag specifier for zkg install command #78

Merged

Conversation

javabrett
Copy link
Contributor

Summary of the contribution

zkg install command wouldn't work for me per the docs:

   7 | >>> RUN zkg install --force seisollc/zeek-kafka --version 1.2.0 --user-var librdkafka_root=/usr

9.663 error: invalid package "seisollc/zeek-kafka": no such commit, branch, or version tag: "1.2.0"

Version string needs to exactly match the tag name, so v1.2.0 for latest release.

#6 0.144 + zkg install --force seisollc/zeek-kafka --version v1.2.0 --user-var librdkafka_root=/usr
#6 87.36 Running unit tests for "zeek/seisollc/zeek-kafka"
#6 87.36 Installing "zeek/seisollc/zeek-kafka"
#6 111.2 Installed "zeek/seisollc/zeek-kafka" (v1.2.0)
#6 111.2 Loaded "zeek/seisollc/zeek-kafka"
#6 111.2 + zeek -N Seiso::Kafka
#6 111.5 Seiso::Kafka - Writes logs to Kafka (dynamic, version 0.3.0)

Hopefully this change doesn't upset bump-version.

Testing

...

Checklist

  • Confirm that any associated issues are indicated in the pull request title
  • Rebase your PR against the latest commit within the target branch
  • Include steps to verify and test the intended change
  • Write or update unit tests and/or integration tests to verify your changes
  • Run shellcheck against any new or updated shell scripts, indicating the reasoning behind any disabled checks
  • Indicate whether or not this is a breaking change
  • Ensure that any new dependencies are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0

Copy link
Collaborator

@ottobackwards ottobackwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ottobackwards ottobackwards merged commit c14bc87 into SeisoLLC:main Nov 4, 2023
2 checks passed
@javabrett javabrett deleted the readme-fix-version-tag-string branch November 11, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants