Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typechecking with matplotlib 3.8.0 #969

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

jklaise
Copy link
Contributor

@jklaise jklaise commented Sep 27, 2023

Fixes #966.

Most of these are just type ignores as they seem to appear as red herrings (types already narrowed implicitly from union types). It would take extra dedicated effort to trace through our type logic and the one for matplotlib and possibly implementation changes to fix this up properly.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #969 (50291aa) into master (54d0c95) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 80.95%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #969   +/-   ##
=======================================
  Coverage   85.23%   85.23%           
=======================================
  Files          74       74           
  Lines        8832     8834    +2     
=======================================
+ Hits         7528     7530    +2     
  Misses       1304     1304           
Files Coverage Δ
alibi/explainers/pd_variance.py 98.37% <100.00%> (ø)
alibi/prototypes/protoselect.py 93.36% <0.00%> (ø)
alibi/utils/visualization.py 48.10% <62.50%> (ø)

... and 1 file with indirect coverage changes

@jklaise jklaise merged commit 4a4f505 into SeldonIO:master Sep 27, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

matplotlib 3.8.0 type hints for public APIs result in type-checking failures
1 participant