fix: Make status.selector field optional (#5985)

* make Selector field optional for model status * generate files
SeldonIO · Oct 24, 2024 · 752e489 · 752e489
1 parent 81b3d29
commit 752e489
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 7 deletions.
diff --git a/k8s/helm-charts/seldon-core-v2-crds/templates/seldon-v2-crds.yaml b/k8s/helm-charts/seldon-core-v2-crds/templates/seldon-v2-crds.yaml
@@ -343,8 +343,6 @@ spec:
                 type: integer
               selector:
                 type: string
-            required:
-            - selector
             type: object
         type: object
     served: true

diff --git a/k8s/yaml/crds.yaml b/k8s/yaml/crds.yaml
@@ -346,8 +346,6 @@ spec:
                 type: integer
               selector:
                 type: string
-            required:
-            - selector
             type: object
         type: object
     served: true

diff --git a/operator/apis/mlops/v1alpha1/model_types.go b/operator/apis/mlops/v1alpha1/model_types.go
@@ -107,7 +107,7 @@ type InferenceArtifactSpec struct {
 type ModelStatus struct {
 	// Total number of replicas targeted by this model
 	Replicas      int32  `json:"replicas,omitempty"`
-	Selector      string `json:"selector"`
+	Selector      string `json:"selector,omitempty"`
 	duckv1.Status `json:",inline"`
 }
 

diff --git a/operator/config/crd/bases/mlops.seldon.io_models.yaml b/operator/config/crd/bases/mlops.seldon.io_models.yaml
@@ -195,8 +195,6 @@ spec:
                 type: integer
               selector:
                 type: string
-            required:
-            - selector
             type: object
         type: object
     served: true