Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update missing value of MANAGER_LEADER_ELECTION_RETRY_PERIOD_SECS #5087

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saeid93
Copy link
Contributor

@saeid93 saeid93 commented Aug 13, 2023

Fixes #5086 and updated the missing value of MANAGER_LEADER_ELECTION_RETRY_PERIOD_SECS initiating the error mentioned in the issue. I followed the same value of similar fields

- name: MANAGER_LEADER_ELECTION_RENEW_DEADLINE_SECS

Alternatively, we can use the helm default values:

leaderElectionRetryPeriodSecs: 2

Plz let me know if that's preferred.

@seldondev
Copy link
Collaborator

Hi @saeid93. Thanks for your PR.

I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@ukclivecox ukclivecox self-requested a review August 14, 2023 08:30
@ukclivecox ukclivecox added the v1 label Aug 14, 2023
@saeid93
Copy link
Contributor Author

saeid93 commented Aug 15, 2023

Hi @cliveseldon , is the error related to the commit? Doc tests are causing errors but as far as I understand the commits' changes are not linked to the doc.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V1 Makefile deployment installation bug
4 participants