Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove timeout in envoy #5099

Merged
merged 1 commit into from
Aug 21, 2023
Merged

fix: Remove timeout in envoy #5099

merged 1 commit into from
Aug 21, 2023

Conversation

ukclivecox
Copy link
Contributor

Provides a short term fix for hard-wired timeouts in Envoy of 60s by setting to 0 (no timeout).
Ideally, in future this should be configurable on a per Model/Pipleine basis

@ukclivecox ukclivecox added the v2 label Aug 21, 2023
@ukclivecox ukclivecox changed the title Remove timoeut in envoy fix: Remove timeout in envoy Aug 21, 2023
@ukclivecox ukclivecox merged commit 10e9a7d into SeldonIO:v2 Aug 21, 2023
3 of 4 checks passed
agrski
agrski reviewed Aug 21, 2023
View reviewed changes
Copy link
Contributor

@agrski agrski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to note with this is that Envoy will be holding on to a lot more connections as it'll be up to the connecting client to disconnect. We're more likely to see resource exhaustion without any kind of load-shedding within Envoy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrski agrski agrski left review comments

@adriangonz adriangonz adriangonz approved these changes

@RafalSkolasinski RafalSkolasinski Awaiting requested review from RafalSkolasinski

Assignees
No one assigned
Labels
v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ukclivecox @adriangonz @agrski