Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dataflow): add SELDON_POD_NAMESPACE env var for Docker deployments #5101

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

adriangonz
Copy link
Contributor

What this PR does / why we need it:
Following #5072, the pod.namespace arg is now mandatory for the Dataflow engine. However, this wasn't reflected on the Docker Compose files for local deployments, causing the `Dataflow container to crash at start time with:

Exception in thread "main" com.natpryce.konfig.Misconfiguration: pod.namespace property not found; searched:
 - --pod-namespace in command-line parameters
 - SELDON_POD_NAMESPACE in environment variables
 - pod.namespace in resource local.properties

        at com.natpryce.konfig.Configuration$get$1.invoke(konfig.kt:91)
        at com.natpryce.konfig.Configuration$get$1.invoke(konfig.kt:85)
        at com.natpryce.konfig.Configuration$DefaultImpls.getOrElse(konfig.kt:109)
        at com.natpryce.konfig.Override.getOrElse(konfig.kt:314)
        at com.natpryce.konfig.Configuration$DefaultImpls.get(konfig.kt:91)
        at com.natpryce.konfig.Override.get(konfig.kt:314)
        at io.seldon.dataflow.Main.main(Main.kt:39)

This PR adds a default SELDON_POD_NAMESPACE env var on the Docker Compose config to make sure the Dataflow engine can come up.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@ukclivecox ukclivecox merged commit 0ade28b into SeldonIO:v2 Aug 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants