fix(dataflow): add SELDON_POD_NAMESPACE env var for Docker deployments #5101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Following #5072, the
pod.namespace
arg is now mandatory for the Dataflow engine. However, this wasn't reflected on the Docker Compose files for local deployments, causing the `Dataflow container to crash at start time with:This PR adds a default
SELDON_POD_NAMESPACE
env var on the Docker Compose config to make sure the Dataflow engine can come up.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: