Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): [SCv1] Add a section about loading custom HuggingFace models #5105

Conversation

vtaskow
Copy link
Contributor

@vtaskow vtaskow commented Aug 23, 2023

What this PR does / why we need it:
Following #5104, we need a demo of how our users might use custom HuggingFace models to make predictions.

Testing

  • ran k apply -f and created a SeldonDeployment resource successfully
  • predicted successfully

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@vtaskow vtaskow marked this pull request as ready for review August 23, 2023 13:52
@vtaskow vtaskow changed the title feat(docs): [HuggingFace] Add section about loading custom models feat(docs): [SCv1] Add section about loading custom HuggingFace models Aug 23, 2023
@vtaskow vtaskow changed the title feat(docs): [SCv1] Add section about loading custom HuggingFace models feat(docs): [SCv1] Add a section about loading custom HuggingFace models Aug 23, 2023
@vtaskow vtaskow self-assigned this Aug 23, 2023
doc/source/servers/huggingface.md Outdated Show resolved Hide resolved
doc/source/servers/huggingface.md Outdated Show resolved Hide resolved
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@vtaskow vtaskow force-pushed the V2D-1268-docs-servers-hf-add-section-about-loading-custom-models branch from 1025292 to bf3a340 Compare August 29, 2023 14:12
@vtaskow vtaskow merged commit 6a00ff9 into SeldonIO:master Aug 29, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants