fix: Upgrade go 1.22 #5990
Merged
fix: Upgrade go 1.22 #5990
+113
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lc525
reviewed
Oct 28, 2024
.github/workflows/draft-release.yml
Outdated
| @@ -69,9 +69,9 @@ jobs: | |||
| node-version: 14 | |||
|
|
|||
| - name: Setup Go | |||
| uses: actions/setup-go@v4 | |||
| uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.1 | |||
There was a problem hiding this comment.
Could we pin to @v5 instead of the actual hash? The setup-go docs seem to reference the major version, so I would assume they would want to keep things mostly compatible within the same major version (so we wouldn't get issues with the action being updated under us, but instead we could benefit from things like security updates)
lc525
reviewed
Oct 30, 2024
tests/integration/go.mod
Outdated
| @@ -1,77 +1,77 @@ | |||
| module github.com/seldonio/seldon-core/tests/integration/v2 | |||
|
|
|||
| go 1.21 | |||
| go 1.22.0 | |||
There was a problem hiding this comment.
Suggested change
| go 1.22.0 | |
| go 1.22 |
There was a problem hiding this comment.
Thanks for noticing this is updated
lc525
reviewed
Oct 30, 2024
lc525
approved these changes
Nov 8, 2024
|
Tested is using smoke test with docker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR upgrades to
0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32because tag can be changed but she can'tPlease note that
Which issue(s) this PR fixes:
Fixes #INFRA-1151