feat(scheduler): exposing the deleted resource ttl as a CLI param #5994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driev
changed the title
sakoush
approved these changes
Oct 30, 2024
scheduler/cmd/scheduler/main.go
Outdated
| @@ -115,6 +116,9 @@ func init() { | |||
|
|
|||
| // Timeout for scheduler to be ready | |||
| flag.UintVar(&schedulerReadyTimeoutSeconds, "scheduler-ready-timeout-seconds", 300, "Timeout for scheduler to be ready") | |||
|
|
|||
| // This TTL is set in badger DB | |||
| flag.UintVar(&deletedResourceTTL, "deleted-resource-ttl", 1440, "TTL for deleted experiments and pipelines (in minutes)") | |||
There was a problem hiding this comment.
nit: should the name indicate the time resolution to reduce confusing. eg. deleted-resource-ttl-minutes
There was a problem hiding this comment.
should we use utils.DeletedResourceTTL as default instead of 1440?
There was a problem hiding this comment.
went with seconds in the end, as it's easier to test...
I've removed utils.DeletedResourceTTL as it's no longer required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Making the deleted resource tll configurable.
Which issue(s) this PR fixes:
Fixes # internal: INFRA-901
Special notes for your reviewer:
TODO: