Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Migrated the traefik service mesh content #5996

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

Rajakavitha1
Copy link
Contributor

@Rajakavitha1 Rajakavitha1 commented Oct 26, 2024

What this PR does / why we need it:

Address the content migration issue in gitbook: https://docs.seldon.ai/seldon-core-2/kubernetes/service-meshes/traefik that was reported by @sakoush

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer: migrated the content based on https://docs.seldon.io/projects/seldon-core/en/v2.6.0/contents/kubernetes/service-meshes/traefik/index.html

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Rajakavitha1
❌ Rakavitha Kodhandapani


Rakavitha Kodhandapani seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Rajakavitha1 Rajakavitha1 marked this pull request as ready for review October 26, 2024 07:20
Copy link
Member

@sakoush sakoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Is there a way to render this as a warning / more explicit note in gitbook?

fixed the hint block
@Rajakavitha1
Copy link
Contributor Author

LGTM.

Is there a way to render this as a warning / more explicit note in gitbook?

Just made the fix. Thanks for pointing.

@Rajakavitha1 Rajakavitha1 merged commit d395333 into v2 Oct 28, 2024
3 of 5 checks passed
@Rajakavitha1 Rajakavitha1 deleted the service-meshes-rajie branch October 28, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants