-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): add more configuration details to the HPA docs #6019
Conversation
5d9ff48
to
7c30b34
Compare
8ed46ba
to
046daa9
Compare
e109762
to
2d232de
Compare
Should we link to this page so users understand the metrics Core 2 makes available to them (perhaps in the Installing and configuring the Prometheus Adapter) section? |
Consider renaming the section titled Seldon Core 2 scheduler interactions with HPA-based scaling? I think this is an important section, but I wouldn't know from the title that there is is relevant operational information there related to resource states, handling spikes, tips on configuration... perhaps something like Operational Guidelines for coordinating HPA Scaling and Core 2 Scheduling? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Have made some minor edits and possible suggestions in comments
* improve overall docs clarity * explain prometheus-adapter ConfigMap customisation options * mention that `spec.replicas` needs to be present in the Model CR for HPA to work * change `apply` to `replace` in kubectl command updating the prometheus-adapter ConfigMap * clarify in what namespaces we should load the various manifests in the example * add cluster operation guidelines
08081b3
to
4d0b398
Compare
4d0b398
to
4cdee0d
Compare
Co-authored-by: Rajakavitha Kodhandapani <krajakavitha@gmail.com>
spec.replicas
needs to be present in the Model CR for HPA to workapply
toreplace
in kubectl command updating the prometheus-adapter ConfigMap