fix(dataflow): make each replica use unique subscription names #6021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following SeldonIO#6020, it was no longer possible to have multiple replicas of dataflow-engine subscribing simultaneously to the scheduler, because all were connecting with the same subscriber name, and a lock was added per name, first waiting the disconnection of the old subscriber before allowing a new one to progress. We update the dataflow-engine code so that each replica connects with its own hostname as the subscriber name. If the hostname can not be determined, we subscribe with the name `seldon-dataflow-engine-` followed by a hex string of 50 random characters. The subscriber name can also be explicitly controlled by passing the `--dataflow-replica-id` argument or the `DATAFLOW_REPLICA_ID` environment variable, wich will take precedence, in that order, to setting the value as the hostname.
lc525
force-pushed
the
quickfix/dataflow-subscriber-name
branch
from
8e7a825
to
f53945c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #6020, it was no longer possible to have multiple replicas of dataflow-engine subscribing simultaneously to the scheduler, because all were connecting with the same subscriber name, and a lock was added per name, first waiting the disconnection of the old subscriber before allowing a new one to progress.
We update the dataflow-engine code so that each replica connects with its own hostname as the subscriber name. If the hostname can not be determined, we subscribe with the name
seldon-dataflow-engine-followed by a hex string of 50 random characters.The subscriber name can also be explicitly controlled by passing the
--dataflow-replica-idargument or theDATAFLOW_REPLICA_IDenvironment variable, wich will take precedence, in that order, to setting the value as the hostname.Special notes for your reviewer: