Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Merge changes from v2 for release 2.8.5 (4) #6032

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Conversation

sakoush
Copy link
Member

@sakoush sakoush commented Nov 6, 2024

No description provided.

driev and others added 4 commits November 4, 2024 09:22
)

* exposing the deleted resource ttl as a CLI param

* switching to seconds and adding a little test for the cleanup functions

* merge v2

* Revert "merge v2"

This reverts commit 4cf8644.
* always send model events for deleted models

* trying to make it easier to read

* fix broken logic

* simplify loop

* replace recursive call with a loop

* add more logs and update one condition for clarity
* improve overall docs clarity
* explain prometheus-adapter ConfigMap customisation options
* mention that `spec.replicas` needs to be present in the Model CR for HPA to work
* change `apply` to `replace` in kubectl command updating the prometheus-adapter ConfigMap
* clarify in what namespaces we should load the various manifests in the example
* add cluster operation guidelines

Co-authored-by: Rajakavitha Kodhandapani <krajakavitha@gmail.com>
* review with doc improvements suggestions & fixes

---------

Co-authored-by: paulb-seldon <141156400+paulb-seldon@users.noreply.github.com>
Co-authored-by: Rajakavitha Kodhandapani <krajakavitha@gmail.com>
* use generation id to bootstrap versions

* add event type for sync operation

* move event to response

* introduce a second stage of sync process after the scheduler is ready

* send the right resources based on the event type for the control plane

* update control plane test

* add test coverage

* update control plane test

* allow model progressing status update

* add test for generation id

* Update scheduler/pkg/store/memory.go

Co-authored-by: Lucian Carata <lc525@users.noreply.github.com>

---------

Co-authored-by: Lucian Carata <lc525@users.noreply.github.com>
@sakoush sakoush requested a review from lc525 as a code owner November 6, 2024 15:55
@sakoush sakoush added the v2 label Nov 6, 2024
Copy link
Member

@lc525 lc525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, +1 for 2.8.5-rc4!

@sakoush sakoush merged commit 8b48483 into release-2.8 Nov 6, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants