Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: Integrated docker config for changing owner while creating container for better download support #1947

Closed
diyoyo opened this issue Sep 18, 2023 · 7 comments · Fixed by #2056

Comments

@diyoyo
Copy link

diyoyo commented Sep 18, 2023

Feature and motivation

I just read the README file of the repo, and noticed that I had read some interesting lines while setting up Jupyter-Spark containers.

Here is what is reads:

    sudo docker run  \
        -d \
        --name jupyter-spark \
        --restart always \
        --shm-size 512M \
        --user root \
        -e NB_USER=$mainuser \
        -w "/home/${NB_USER}/" \
        -e CHOWN_HOME=yes \
        -p 8888:8888 \
...

And indeed, it does reconfigure the rights in the virtual environment created by the docker.
So maybe there could be a similar proposal for selenium-node.

Usage example

I would use this to avoid users to forget to perform the workaround mentioned at the bottom of the README file.

PS: Also, the README file could be edited to mention whether or not, in addition to the workaround, one should set the --enable-managed-downloads truesomewhere ?
Is it by default or do we need: -e SE_OPTS="--enable-managed-downloads true"

Thanks.

@github-actions
Copy link

@diyoyo, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@VietND96
Copy link
Member

VietND96 commented Dec 5, 2023

Hi @diyoyo, --enable-managed-downloads true is not enabled by default. We have to set via -e SE_OPTS="--enable-managed-downloads true" only.

@diemol
Copy link
Member

diemol commented Dec 5, 2023

@diyoyo did you test that? Does that actually removes the need for the work around?

@VietND96
Copy link
Member

VietND96 commented Dec 5, 2023

@diemol, I am testing this, if it works I think we also can close 2 PRs are pending on removal of chmod 777

@diemol
Copy link
Member

diemol commented Dec 5, 2023

Sounds good, then we can add this to the README. Thanks!

@diyoyo
Copy link
Author

diyoyo commented Dec 8, 2023

I haven't tested it actually as I had other priorities, but I'm glad to hear it works 😄

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants