-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🚀 Feature]: Integrated docker config for changing owner while creating container for better download support #1947
Comments
@diyoyo, thank you for creating this issue. We will troubleshoot it as soon as we can. Info for maintainersTriage this issue by using labels.
If information is missing, add a helpful comment and then
If the issue is a question, add the
If the issue is valid but there is no time to troubleshoot it, consider adding the
If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C),
add the applicable
After troubleshooting the issue, please add the Thank you! |
Hi @diyoyo, |
@diyoyo did you test that? Does that actually removes the need for the work around? |
@diemol, I am testing this, if it works I think we also can close 2 PRs are pending on removal of chmod 777 |
Sounds good, then we can add this to the README. Thanks! |
I haven't tested it actually as I had other priorities, but I'm glad to hear it works 😄 |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Feature and motivation
I just read the README file of the repo, and noticed that I had read some interesting lines while setting up Jupyter-Spark containers.
Here is what is reads:
And indeed, it does reconfigure the rights in the virtual environment created by the docker.
So maybe there could be a similar proposal for selenium-node.
Usage example
I would use this to avoid users to forget to perform the workaround mentioned at the bottom of the README file.
PS: Also, the README file could be edited to mention whether or not, in addition to the workaround, one should set the
--enable-managed-downloads true
somewhere ?Is it by default or do we need:
-e SE_OPTS="--enable-managed-downloads true"
Thanks.
The text was updated successfully, but these errors were encountered: