Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change right for /opt/bi/*.sh file. Impact of change on Base/Dockerfi… #1964

Closed
wants to merge 3 commits into from

Conversation

eravion
Copy link

@eravion eravion commented Oct 2, 2023

…le file (replace 777 by 775)

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@diemol
Copy link
Member

diemol commented Oct 3, 2023

Can you explain better why this is needed?

@eravion
Copy link
Author

eravion commented Oct 4, 2023

Hello @diemol ,
Change needed because of #1963
Our security Dept. does not allow 777 rights on folder. Including on docker.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the COPY with chmod as mentioned in the Docker documentation https://docs.docker.com/engine/reference/builder/#copy

@VietND96
Copy link
Member

VietND96 commented Dec 3, 2023

Hello @diemol ,

Change needed because of #1963

Our security Dept. does not allow 777 rights on folder. Including on docker.

Hi @eravion, can you please combine this commit into #1963 to see all changes needed, test it and merge those together?

@VietND96
Copy link
Member

This one is also considered via PR #2056. You can review it once.

@VietND96
Copy link
Member

Close this PR as per comments in #1963

@VietND96 VietND96 closed this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants