Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Workflow to Lint and Test Helm Chart #2002

Closed
wants to merge 6 commits into from
Closed

Github Workflow to Lint and Test Helm Chart #2002

wants to merge 6 commits into from

Conversation

amardeep2006
Copy link
Contributor

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

This is related to #1975

  1. Added a workflow to lint and test helm charts
  2. Added maintainer info in Charts.yml
  3. Did one time linting for issues thrown by linter

Motivation and Context

It will do one basic testing for helm chart by linting and installing in Kubernetes. The advanced testing can be built on top of this.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ amardeep2006
❌ Amar Deep Singh


Amar Deep Singh seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@diemol
Copy link
Member

diemol commented Nov 10, 2023

@amardeep2006 can you please check the commits? One of them is not recognizing your GitHub user.

@amardeep2006
Copy link
Contributor Author

@diemol That is fine , all commits are mine. Probably I messed up git profile in my local machine.

@diemol
Copy link
Member

diemol commented Nov 10, 2023

I know, but the CLA needs to be signed by the commits owner.

@diemol
Copy link
Member

diemol commented Nov 10, 2023

image

@amardeep2006
Copy link
Contributor Author

I am closing the PR , not sure how to correct the commits. I will raise again from a new branch with clean commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants