Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected typo in selenium grid charts #2010

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Conversation

Thab310
Copy link
Contributor

@Thab310 Thab310 commented Nov 13, 2023

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Spelling error correction

Motivation and Context

This change will make the comment make sense and will help avoid ambiguity.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [X ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [X ] I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Nov 13, 2023

CLA assistant check
All committers have signed the CLA.

@diemol
Copy link
Member

diemol commented Nov 14, 2023

@amardeep2006 do you know why is the linting now failing?

@diemol
Copy link
Member

diemol commented Nov 14, 2023

@amardeep2006

✖︎ selenium-grid => (version: "0.25.0", path: "charts/selenium-grid") > chart version not ok. Needs a version bump!

Why? We do not need to bump the version for this change.

@amardeep2006
Copy link
Contributor

@diemol Yes seems ct has linting rule which expects version to be bumped up as well.
Let me know if we need to disable this check. There is a flag called --check-version-increment which can be used to control this behavior. --check-version-increment

Please let me know if this is required or we are ok with version bump from contributors.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Thab310!

@diemol diemol merged commit 373c3c3 into SeleniumHQ:trunk Nov 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants