Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(chart): Parallel tests execution against autoscaling in Kubernetes #2046

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

VietND96
Copy link
Member

@VietND96 VietND96 commented Dec 5, 2023

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

test(chart): Parallel tests execution against autoscaling in Kubernetes

Motivation and Context

Reuse existing sanity tests within the implementation of the concurrent executor to test the feature Selenium Grid Autoscaling on Kubernetes using KEDA.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
@VietND96 VietND96 requested a review from diemol December 5, 2023 05:47
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern is... what do we do when it fails? How do we know what needs to be done if it fails?

@VietND96
Copy link
Member Author

VietND96 commented Dec 5, 2023

You mean how do we know what needs to be done for the test failed or the fix needed for grid or chart?

@diemol
Copy link
Member

diemol commented Dec 5, 2023

You mean how do we know what needs to be done for the test failed or the fix needed for grid or chart?

Exactly. Since this is testing an external dependency (keda).

@VietND96
Copy link
Member Author

VietND96 commented Dec 5, 2023

Yes, when I was adding this, I thought to guarantee regression issue only. For example use cases

  • Someone raises PR to bump the default KEDA version used in chart.
  • Someone raises PR to improve the chart template related to feat autoscaling

If this test failed...the author should rework it.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add it then. If it gets unstable we need to analyze how much time we are investing in it.

Thanks, @VietND96!

@VietND96
Copy link
Member Author

VietND96 commented Dec 5, 2023

Thank you! I will merge this.

@VietND96 VietND96 merged commit c4e4024 into SeleniumHQ:trunk Dec 5, 2023
6 checks passed
@VietND96 VietND96 deleted the helm-chart branch December 5, 2023 13:44
@VietND96 VietND96 self-assigned this Dec 6, 2023
@VietND96 VietND96 linked an issue Dec 6, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm Charts maintainer needed
2 participants