Fix: page scrolls to top when opening dialog

[zenpk]

Fixes #1411

After some searching, I was very lucky to find the easiest solution, which is described in this comment:

PS Omitting the height: 100% effectively locks the scrolling at the current position without the jumping - on latest Chrome, at least. – zerm

https://stackoverflow.com/questions/3656592/how-to-programmatically-disable-page-scrolling-with-jquery

(I actually have no idea why it behaves like that...)

P.S. There's also a JavaScript solution but is not even close as neat: https://stackoverflow.com/questions/4770025/how-to-disable-scrolling-temporarily

[Sendouc]

Hey! Do you get this kind of behavior on your machine as well? I see the background jumping a bit horizontally on dialog open. It's a small thing but I wonder what is causing it 🤔

Screen.Recording.2023-07-18.at.0.57.07.mov

[zenpk]

@Sendouc I just tested and yes, I got the same behavior. It is caused by the absence of the scrollbar. So the "cause chain" is: overflow: hidden -> scrollbar hidden -> display moves horizontally

[Sendouc]

Ahh ok yeah that makes sense but that's ok for now. Good work :)