Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded remix-auth-oauth2 to latest version (2.3.0) #1861

Closed
wants to merge 8 commits into from

Conversation

ElementUser
Copy link
Contributor

@ElementUser ElementUser commented Aug 25, 2024

Issue Link: #1852

Description of Changes

Upgraded remix-auth-oauth2 to latest version (2.3.0)

===

Note: will require a rebuild & reupload of the bun lock file after merging other Pull Requests that contain dependency changes.

@ElementUser
Copy link
Contributor Author

@Sendouc note: I couldn't actually test the auth changes (since I don't develop Discord bots & don't know how to leverage the auth flow in the app). It may be best if you test the changes since you already have everything set up to do so - I've made all the refactoring changes I can in the code to follow the latest convention/syntax from the official documentation without VSCode giving me typing/non-existing argument errors

So in theory all you need to do is just test it on your end & see if it works

@Sendouc
Copy link
Owner

Sendouc commented Sep 1, 2024

Hmm seems like something else might be needed

image

@ElementUser
Copy link
Contributor Author

ElementUser commented Sep 1, 2024

Hmm seems like something else might be needed

image

Thanks for testing @Sendouc!

I did some issue lookups in the remix-auth-oauth2 repo & found this: sergiodxa/remix-auth-oauth2#94

Since v2.1.0, the default authentication strategy was set to request_body. I took a look at the Typing for the OAuth2StrategyOptions options based on the linked issue above, and found this in the index.ts file:

/**
     * The method to use to authenticate with the Identity Provider, this can be
     * either `http_basic_auth` or `request_body`.
     * @default "request_body"
     */
    authenticateWith?: "http_basic_auth" | "request_body";

So request_body is the default auth method selected - does Discord/your app use http_basic_auth to authenticate? If so, we can try adding in authenticateWith: "http_basic_auth" and see if that fixes it. Otherwise, I don't know what else to do at the moment unless I can get the auth flow set up locally

@Sendouc Sendouc closed this Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants