Fix several clang-tidiy issues #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
psachs
commented
Oct 24, 2024
psachs
commented
- Add unused annotations
- Fix missing explicit casting issues
- Remove "_" prefix from header guards and make them readable
* Add unused annotations * Fix missing explicit casting issues * Remove "_" prefix from header guards and make them readable
Rename setupAndStartBleScans to setupBleScans since it only configures the BLE scanning. Create new internal function to start BLE scans that gets called from the begin() method. keepAlive doesn't need to be called on init to start the scanning. It can be used to re-start in case of errors as documented.
Use uint64_t as interface between NimBLE client and SensiScan as we only convert it into a invalid string and back into an uint64_t. Add constructor and destructure to NimBLE client to better represent the life-cycle of this class. Remove squash method from SensiScan as it is not required anymore.
qfisch
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.