Pid::new returns Result instead of asserting in case of an error #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trnila
force-pushed
the
pid-without-assert
branch
from
ee65c8a to
4b2f6a4
Compare
psachs
reviewed
Oct 23, 2024
The Pid::new() function can be used, for example, with untrusted PID received from master without causing a panic. This patch may introduce a breaking change, but it can be addressed with a simple fix by checking the Result.
trnila
force-pushed
the
pid-without-assert
branch
from
4b2f6a4 to
d3baaa0
Compare
trnila
changed the title
psachs
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Pid::new()function can be used, for example, with untrusted PID received from master without causing a panic.This patch may introduce a breaking change, but it can be addressed with a simple fix by checking the
Option.The
Optionis used as there are no meaningful possible errors.Check the following: