Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images built with docker-build use baseimage descriptions #10

Open
ypcs opened this issue Sep 12, 2024 · 0 comments
Open

Images built with docker-build use baseimage descriptions #10

ypcs opened this issue Sep 12, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ypcs
Copy link
Contributor

ypcs commented Sep 12, 2024

In

--label "org.opencontainers.image.revision=${{ github.sha }}" \
we already set pointer to the git commit from which image was built. However, we don't touch the image description, which currently means that most of our images use default value - "Seravo Ubuntu basebox" as value. This is confusing.

We should add new input to the action, for the description. If easily doable, by default we could just remove the description (when input is empty string), but if it's set, we could use it to override the value we've set previously.

@ypcs ypcs added the bug Something isn't working label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant