Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend tests #13

Open
ottok opened this issue Apr 21, 2020 · 0 comments
Open

Extend tests #13

ottok opened this issue Apr 21, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ottok
Copy link
Contributor

ottok commented Apr 21, 2020

Currently Gnitpick does not complain anything about a commit like:

 Gnitpick inspecting git revisions range origin/master..HEAD
  commit 59705a9aa1ce99b5cfc7c1617f1f10bed29d9934
  Author: HACKING-STATION\gunhaxxor <example@example.com>
  Date:   Tue Apr 21 12:19:02 2020 +0200
  
      Fixed issue #131
 Inspecting commit 59705a9aa1ce99b5cfc7c1617f1f10bed29d9934:
 Gnitpick commit inspection passed!

Ideally it would check that author name looks like a real name.

Also it would be cool to detect past tense from the git title and enforce imperative form.
@ottok ottok added the help wanted Extra attention is needed label Apr 21, 2020
@ottok ottok added enhancement New feature or request good first issue Good for newcomers and removed help wanted Extra attention is needed labels Jun 7, 2020
@elguitar elguitar changed the title Exend tests Extend tests Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ottok