Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Gitlab-CI #7

Open
ottok opened this issue Mar 29, 2020 · 2 comments
Open

Add support for Gitlab-CI #7

ottok opened this issue Mar 29, 2020 · 2 comments
Assignees
@ottok
Labels
enhancement New feature or request

Comments

@ottok
Copy link
Contributor

ottok commented Mar 29, 2020

Gnitpick was initially written with Github and Travis-CI in mind. But if might also be useful on Gitlab-CI.

We should incorporate checking for CI_MERGE_REQUEST_SOURCE_BRANCH_SHA and CI_MERGE_REQUEST_TARGET_BRANCH_SHA to get the Gitlab-CI Merge Request commit range.

See https://docs.gitlab.com/ee/ci/variables/predefined_variables.html
@ottok
Copy link
Contributor Author

ottok commented Apr 14, 2020 •
edited
Loading

Tested in https://salsa.debian.org/mariadb-team/mariadb-10.4/-/jobs/657676 - works well! Just need to document this properly and add support for CI_MERGE_* variables like we have in Travis-CI.

@ottok ottok self-assigned this Apr 14, 2020
@ottok
Copy link
Contributor Author

ottok commented Apr 20, 2020

Without the variables, a fork running long behind upstream master will get way too many commits comparing only origin/master..HEAD. See example https://gitlab.com/CsatariGergely/fevermap/-/jobs/516483911

@ottok ottok added the enhancement New feature or request label Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ottok ottok

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ottok