allow downloading of recent versions of chrome #537

david-engelmann · 2023-07-19T13:04:09Z

the hosting path for chrome has changed for recent versions

david-engelmann · 2023-07-19T13:56:42Z

need to patch File parsing of response, currently breaking because it's returning a file with .exe in the name

webdriver_manager/drivers/chrome.py

david-engelmann · 2023-07-19T17:31:53Z

lets wait to merge, I'm still seeing some fails in CI/CD versions, I've almost resolved

david-engelmann · 2023-07-19T20:18:10Z

I've tested my little heart out, and it seems to be working locally and within my CI/CD pipelines. We should run the testing suite to confirm everything is good to go

david-engelmann · 2023-07-20T10:27:56Z

i adjusted so that the failing 114.0.5735.198 test pass

webdriver_manager/drivers/chrome.py

…n/webdriver_manager into de-upgrade-chrome-version

tonycapone · 2023-07-21T16:27:47Z

Hi @david-engelmann. Tried out your repo and branch to get around the url issue,
pip install git+https://github.com/david-engelmann/webdriver_manager.git@de-upgrade-chrome-version

But I get this error. Any ideas?

  File "/usr/local/lib/python3.10/site-packages/webdriver_manager/chrome.py", line 39, in install
    driver_path = self._get_driver_path(self.driver)
  File "/usr/local/lib/python3.10/site-packages/webdriver_manager/core/manager.py", line 30, in _get_driver_path
    file = self._download_manager.download_file(driver.get_driver_download_url())
  File "/usr/local/lib/python3.10/site-packages/webdriver_manager/drivers/chrome.py", line 63, in get_driver_download_url
    release_version = self.get_latest_patch_version_for_build_version(build_version=driver_version_to_download)
  File "/usr/local/lib/python3.10/site-packages/webdriver_manager/drivers/chrome.py", line 117, in get_latest_patch_version_for_build_version
    return data["builds"][build_version]["version"]
KeyError: '115.0.5790.102'

david-engelmann · 2023-07-21T17:00:40Z

@tonycapone I believe that should work now

SergeyPirogov · 2023-07-22T08:05:04Z

Thanks @david-engelmann, could you add a specific test for chrome v115?

SergeyPirogov · 2023-07-22T15:01:09Z

I've merged fixes for chrome. Please test and provide a feedback

david-engelmann · 2023-07-22T15:24:35Z

Thanks @david-engelmann, could you add a specific test for chrome v115?

@SergeyPirogov It's unclear how I define test cases for certain chrome versions. the test failing on 114 is because that version (114.0.5735.198) doesn't exist. I was looking at your merge conflicts and I couldn't follow the logic for most of them. In particular, the removal of support for the short form version 115 and the build version 115.0.5735 etc. I can remove that logic but it will require users to use the patched version of their browser which changes frequently.

SergeyPirogov · 2023-07-22T15:49:53Z

@david-engelmann I've fixed this in github actions by installing latest Google Chrome for every os

david-engelmann · 2023-07-22T15:54:35Z

@SergeyPirogov Perfect! I adjusted the parameters and os_type logic. The only conflict I left in was the short form support for version xxx and version xxx.x.xxxx.

SergeyPirogov · 2023-07-22T15:56:14Z

@david-engelmann please point to exect lines of code, because its hard to get what do you mean by short version

david-engelmann · 2023-07-22T16:14:38Z

webdriver_manager/drivers/chrome.py


-        raise Exception(f"No such driver version {browser_version} for {platform}")
+    def get_latest_release_for_version(self, version):


@SergeyPirogov Here is the function for latest release by short version ie. 115

david-engelmann · 2023-07-22T16:15:17Z

webdriver_manager/drivers/chrome.py

+                return v 
+        return None
+
+    def get_latest_patch_version_for_build_version(self, build_version):


@SergeyPirogov Here is the function for latest release by build version ie. 115.0.5735

So, why do we need it?

@SergeyPirogov The old LATEST_RELEASE url supported those style lookups. ie. https://chromedriver.storage.googleapis.com/LATEST_RELEASE_113 and https://chromedriver.storage.googleapis.com/LATEST_RELEASE_114.0.5735. It was suggested we retain that for versions over 115. Without that, users will have to pass in the full browser version ie. version="114.0.5735.90", which can change frequently. Either way, I'm fine including for backwards compatibility, I'm fine with removing for simplicity and add an exception that explains as suggested by you

I'd postpone this, because what I see know is that browser version is equal to the one mentioned in their driver website. Moreover I think that fix should be applied in method get_url_for_version_and_platform

david-engelmann · 2023-07-22T17:42:51Z

Code merged in #539

david-engelmann · 2023-07-22T17:55:52Z

going to close out and submit a new pr for the short version support feature discussed here

p112913 · 2023-07-22T22:04:17Z

Thanks @david-engelmann for all your hard work on this PR!

grapefruiteater · 2023-07-26T12:21:45Z

Sorry, Chrome changed driver url path.
https://googlechromelabs.github.io/chrome-for-testing/

please re-revise content.

grapefruiteater · 2023-07-26T12:23:18Z

This is my error. Driver path 115.0.5790.110 is not valid from above URL site.

Traceback (most recent call last):
File "C:\Users\11235\Documents\Workfolder\Amazon_GetOrders\Amazon_GetOrders.py", line 73, in
driver_path = ChromeDriverManager().install()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\11235\AppData\Local\Programs\Python\Python311\Lib\site-packages\webdriver_manager\chrome.py", line 39, in install
driver_path = self._get_driver_binary_path(self.driver)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\11235\AppData\Local\Programs\Python\Python311\Lib\site-packages\webdriver_manager\core\manager.py", line 33, in _get_driver_binary_path
file = self._download_manager.download_file(driver.get_driver_download_url())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\11235\AppData\Local\Programs\Python\Python311\Lib\site-packages\webdriver_manager\drivers\chrome.py", line 59, in get_driver_download_url
modern_version_url = self.get_url_for_version_and_platform(driver_version_to_download, os_type)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\11235\AppData\Local\Programs\Python\Python311\Lib\site-packages\webdriver_manager\drivers\chrome.py", line 94, in get_url_for_version_and_platform
raise Exception(f"No such driver version {browser_version} for {platform}")
Exception: No such driver version 115.0.5790.110 for win32

david-engelmann · 2023-07-26T13:44:06Z

@grapefruiteater It appears that the version of Chrome you have is not supported by chrome-for-testing

Derpitron · 2023-07-26T17:20:02Z

@grapefruiteater It appears that the version of Chrome you have is not supported by chrome-for-testing

I am experiencing this issue as well. How can I fix it?

david-engelmann · 2023-07-26T17:29:00Z

@Derpitron I would install a version of chrome that matches a version supported by chrome-for-testing. This link shows everything they support. The main issue is the patch version -> 115.0.5790.110. 102 is the last version supported by google-for-testing

allow downloading of modern_versions of chrome

2b86ad1

david-engelmann mentioned this pull request Jul 19, 2023

Chrome Driver can not be installed with LATEST_RELEASE_115.0.5790 tag #536

Closed

use _http_client

1abbd90

fix filepath creation in File object

185e872

david-engelmann commented Jul 19, 2023

View reviewed changes

webdriver_manager/drivers/chrome.py Outdated Show resolved Hide resolved

david-engelmann added 10 commits July 19, 2023 10:37

set version check to last tag on old url

27527b8

inspect latest_release_url

0038a9c

trying latest with version over 114 is failing

6334866

try to set a working latest_release_url

802af19

fix version check criteria

dfe4626

fix log typo

9617cf3

didnt find version for cicd pipeline, checkout os_type

5201ef7

see determined browser version as well

2fdf352

browser_version not coming back with final 2 digits

70019c1

inspect chrome type passed

d5ef079

AjayIndana approved these changes Jul 19, 2023

View reviewed changes

checkout stdout from read_version_from_cmd

460022b

david-engelmann added 8 commits July 19, 2023 13:48

update version regex pattern

a183a7a

google not chromium

f696681

cleanup comments execpt final url

b160b98

driver_version_to_download inspection

51c3aa7

pipelines running out of space?

e5c93cd

return determined_browser version if over 114

12b8f50

remove license from archive.namelist()

fce4afe

fix the changes in filepath from new zips

03efd0a

set version floor to 114.0.5735.00

75154f0

p112913 reviewed Jul 21, 2023

View reviewed changes

webdriver_manager/drivers/chrome.py Outdated Show resolved Hide resolved

david-engelmann added 2 commits July 21, 2023 10:10

update version check to 115

887b53c

Merge branch 'de-upgrade-chrome-version' of github.com:david-engelman…

f360dc1

…n/webdriver_manager into de-upgrade-chrome-version

ndepaola mentioned this pull request Jul 21, 2023

Desktop Tool Not working properly with Chrome 115.0.5790? chilli-axe/mpc-autofill#154

Closed

support build version and simple version

9fde87a

fail better with unknown version

84272a8

ilkerc mentioned this pull request Jul 21, 2023

There is no such driver by url https://chromedriver.storage.googleapis.com/LATEST_RELEASE_115.0.5790 assafelovic/gpt-researcher#94

Closed

Merge branch 'master' into de-upgrade-chrome-version

841cc09

remove unused param

e9c7f67

david-engelmann commented Jul 22, 2023

View reviewed changes

david-engelmann added 3 commits July 22, 2023 12:56

use determined browser version above 113

5e742c1

issue with using determined_browser_version with 113

2617c16

get_url_for_version_and_platform to return url always

6355e71

david-engelmann closed this Jul 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

allow downloading of recent versions of chrome #537

allow downloading of recent versions of chrome #537

david-engelmann commented Jul 19, 2023

david-engelmann commented Jul 19, 2023

david-engelmann commented Jul 19, 2023

david-engelmann commented Jul 19, 2023

david-engelmann commented Jul 20, 2023 •

edited

Loading

tonycapone commented Jul 21, 2023

david-engelmann commented Jul 21, 2023

SergeyPirogov commented Jul 22, 2023

SergeyPirogov commented Jul 22, 2023

david-engelmann commented Jul 22, 2023

SergeyPirogov commented Jul 22, 2023

david-engelmann commented Jul 22, 2023

SergeyPirogov commented Jul 22, 2023

david-engelmann Jul 22, 2023

david-engelmann Jul 22, 2023

SergeyPirogov Jul 22, 2023

david-engelmann Jul 22, 2023

SergeyPirogov Jul 22, 2023

david-engelmann commented Jul 22, 2023

david-engelmann commented Jul 22, 2023

p112913 commented Jul 22, 2023

grapefruiteater commented Jul 26, 2023

grapefruiteater commented Jul 26, 2023

david-engelmann commented Jul 26, 2023

Derpitron commented Jul 26, 2023

david-engelmann commented Jul 26, 2023


		raise Exception(f"No such driver version {browser_version} for {platform}")
		def get_latest_release_for_version(self, version):

allow downloading of recent versions of chrome #537

allow downloading of recent versions of chrome #537

Conversation

david-engelmann commented Jul 19, 2023

david-engelmann commented Jul 19, 2023

david-engelmann commented Jul 19, 2023

david-engelmann commented Jul 19, 2023

david-engelmann commented Jul 20, 2023 • edited Loading

tonycapone commented Jul 21, 2023

david-engelmann commented Jul 21, 2023

SergeyPirogov commented Jul 22, 2023

SergeyPirogov commented Jul 22, 2023

david-engelmann commented Jul 22, 2023

SergeyPirogov commented Jul 22, 2023

david-engelmann commented Jul 22, 2023

SergeyPirogov commented Jul 22, 2023

david-engelmann Jul 22, 2023

Choose a reason for hiding this comment

david-engelmann Jul 22, 2023

Choose a reason for hiding this comment

SergeyPirogov Jul 22, 2023

Choose a reason for hiding this comment

david-engelmann Jul 22, 2023

Choose a reason for hiding this comment

SergeyPirogov Jul 22, 2023

Choose a reason for hiding this comment

david-engelmann commented Jul 22, 2023

david-engelmann commented Jul 22, 2023

p112913 commented Jul 22, 2023

grapefruiteater commented Jul 26, 2023

grapefruiteater commented Jul 26, 2023

david-engelmann commented Jul 26, 2023

Derpitron commented Jul 26, 2023

david-engelmann commented Jul 26, 2023

david-engelmann commented Jul 20, 2023 •

edited

Loading