Add std::string_view to tests

SergiusTheBest · Oct 5, 2023 · f45f5ca · f45f5ca
1 parent 0d9baad
commit f45f5ca
Show file tree

Hide file tree

Showing 2 changed files with 57 additions and 1 deletion.
diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
@@ -1,4 +1,8 @@
-cmake_minimum_required(VERSION 3.0)
+if(${CMAKE_VERSION} VERSION_LESS 3.27.0)
+    cmake_minimum_required(VERSION 3.0)
+else()
+    cmake_minimum_required(VERSION 3.6)
+endif()
 
 project(PlogTest CXX)
 

diff --git a/test/StringTypes.cpp b/test/StringTypes.cpp
@@ -2,6 +2,10 @@
 #include <plog/Log.h>
 #include "TestAppender.h"
 
+#ifdef __cpp_lib_string_view
+#include <string_view>
+#endif
+
 SCENARIO("string types")
 {
     GIVEN("logger is initialised")
@@ -76,6 +80,30 @@ SCENARIO("string types")
             }
         }
 
+#ifdef __cpp_lib_string_view
+        WHEN("type is std::string_view")
+        {
+            std::string_view var = "test";
+            PLOGI << var;
+
+            THEN("the result is as expected")
+            {
+                CHECK_EQ(testAppender.getMessage(), PLOG_NSTR("test"));
+            }
+        }
+
+        WHEN("type is const std::string_view")
+        {
+            const std::string_view var = "test";
+            PLOGI << var;
+
+            THEN("the result is as expected")
+            {
+                CHECK_EQ(testAppender.getMessage(), PLOG_NSTR("test"));
+            }
+        }
+#endif
+
 #if PLOG_ENABLE_WCHAR_INPUT
         WHEN("type is wchar_t*")
         {
@@ -142,6 +170,30 @@ SCENARIO("string types")
                 CHECK_EQ(testAppender.getMessage(), PLOG_NSTR("test"));
             }
         }
+
+#   ifdef __cpp_lib_string_view
+        WHEN("type is std::wstring_view")
+        {
+            std::wstring_view var = L"test";
+            PLOGI << var;
+
+            THEN("the result is as expected")
+            {
+                CHECK_EQ(testAppender.getMessage(), PLOG_NSTR("test"));
+            }
+        }
+
+        WHEN("type is const std::wstring_view")
+        {
+            const std::wstring_view var = L"test";
+            PLOGI << var;
+
+            THEN("the result is as expected")
+            {
+                CHECK_EQ(testAppender.getMessage(), PLOG_NSTR("test"));
+            }
+        }
+#   endif
 #endif
 
 #ifdef __cplusplus_cli