Deduplicate manifest descriptors in OciImageMetadataRegistry

SgtSilvio · Jul 22, 2024 · 6b5095b · 6b5095b
1 parent 7253069
commit 6b5095b
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 31 deletions.
diff --git a/src/main/kotlin/io/github/sgtsilvio/gradle/oci/internal/registry/OciImageMetadataRegistry.kt b/src/main/kotlin/io/github/sgtsilvio/gradle/oci/internal/registry/OciImageMetadataRegistry.kt
@@ -105,42 +105,44 @@ internal class OciImageMetadataRegistry(val registryApi: OciRegistryApi) {
     ): Mono<OciMultiPlatformImageMetadata> {
         val indexJsonObject = jsonObject(String(index.bytes))
         val indexAnnotations = indexJsonObject.getStringMapOrEmpty("annotations")
-        val metadataMonoList = indexJsonObject.get("manifests") {
-            asArray().toList {
-                val (manifestDescriptorPlatform, manifestDescriptor) = asObject().decodeOciManifestDescriptor()
-                if (manifestDescriptor.mediaType != manifestMediaType) { // TODO support nested index
-                    Mono.empty()
-                } else {
-                    registryApi.pullManifest(
+        val manifestDescriptors = indexJsonObject.get("manifests") {
+            // linked to preserve the platform order
+            asArray().toSet(LinkedHashSet()) { asObject().decodeOciManifestDescriptor() }
+        }
+        indexJsonObject.requireStringOrNull("mediaType", index.mediaType)
+        indexJsonObject.requireLong("schemaVersion", 2)
+
+        val metadataMonoList = manifestDescriptors.map { (manifestDescriptorPlatform, manifestDescriptor) ->
+            if (manifestDescriptor.mediaType != manifestMediaType) { // TODO support nested index
+                Mono.empty()
+            } else {
+                registryApi.pullManifest(
+                    registryUrl,
+                    imageReference.name,
+                    manifestDescriptor.digest,
+                    manifestDescriptor.size.toInt(),
+                    credentials,
+                ).flatMap { manifest ->
+                    if (manifest.mediaType != manifestMediaType) {
+                        throw IllegalStateException("media type in manifest descriptor ($manifestMediaType) and manifest (${manifest.mediaType}) do not match")
+                    }
+                    transformManifestToImageMetadata(
                         registryUrl,
-                        imageReference.name,
-                        manifestDescriptor.digest,
-                        manifestDescriptor.size.toInt(),
+                        imageReference,
+                        manifest,
+                        manifestDescriptor.annotations,
+                        indexAnnotations,
                         credentials,
-                    ).flatMap { manifest ->
-                        if (manifest.mediaType != manifestMediaType) {
-                            throw IllegalStateException("media type in manifest descriptor ($manifestMediaType) and manifest (${manifest.mediaType}) do not match")
-                        }
-                        transformManifestToImageMetadata(
-                            registryUrl,
-                            imageReference,
-                            manifest,
-                            manifestDescriptor.annotations,
-                            indexAnnotations,
-                            credentials,
-                            configMediaType,
-                            layerMediaTypePrefix,
-                        )
-                    }.doOnNext { (platform) ->
-                        if ((manifestDescriptorPlatform != null) && (platform != manifestDescriptorPlatform)) {
-                            throw IllegalStateException("platform in manifest descriptor ($manifestDescriptorPlatform) and config ($platform) do not match")
-                        }
+                        configMediaType,
+                        layerMediaTypePrefix,
+                    )
+                }.doOnNext { (platform) ->
+                    if ((manifestDescriptorPlatform != null) && (platform != manifestDescriptorPlatform)) {
+                        throw IllegalStateException("platform in manifest descriptor ($manifestDescriptorPlatform) and config ($platform) do not match")
                     }
                 }
             }
         }
-        indexJsonObject.requireStringOrNull("mediaType", index.mediaType)
-        indexJsonObject.requireLong("schemaVersion", 2)
         // the same order as in the manifest is guaranteed by mergeSequential
         return Flux.mergeSequential(metadataMonoList)
             // linked to preserve the platform order

diff --git a/src/main/kotlin/io/github/sgtsilvio/gradle/oci/metadata/OciDescriptor.kt b/src/main/kotlin/io/github/sgtsilvio/gradle/oci/metadata/OciDescriptor.kt
@@ -12,7 +12,7 @@ interface OciDescriptor {
     val annotations: SortedMap<String, String>
 }
 
-internal class OciDescriptorImpl(
+internal data class OciDescriptorImpl(
     override val mediaType: String,
     override val digest: OciDigest,
     override val size: Long,