Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RAFT Reverted raft.py param names to dash-case #420

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

RAFT Reverted raft.py param names to dash-case #420

wants to merge 1 commit into from
+2 −2

Conversation

cedricvidal
Copy link
Contributor

Fixes #414

@cedricvidal
Copy link
Contributor Author

@kaiwen129 fyi

@kaiwen129
Copy link
Contributor

@cedricvidal Should we keep things consistent and change chunk_size and openai_key in the args list to hyphen case as well?

@cedricvidal
Copy link
Contributor Author

cedricvidal commented May 11, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiwen129 kaiwen129 kaiwen129 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RAFT raft.py CLI arguments naming broke --embedding-model and --completion-model in PR #410
2 participants
@cedricvidal @kaiwen129