-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ToolACE handler #619
Add ToolACE handler #619
Conversation
Thank you for the PR and welcome! We’re currently busy with a new dataset release. I’ll review your submission later this week and aim to provide feedback by next Monday. Apologies for the delay. |
Hey @XuHwang, one quick question: Where can I find the documentation of this model? Eg, it's input schema, prompt format, etc. |
Thanks for the reply. The format of prompt is actually given in the handler, which is similar to the prompt of LLaMA3. The format should be:
|
So why can't we just use the |
Actually the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compared with the current latest LlamaHandler
from main branch commit eca516a, your ToolACEHandler
differs in the following two ways:
- Your
_format_prompt
has two more\n
after each<|end_header_id|>
tag. This is an oversight on our end; we missed it for the Llama models. I have just fixed it in [BFCL] Fix Llama Handler #626. After the fix, they should be the exact same. - You choose to add the
language_specific_hint
to the end of the last user prompt instead of as part of the function description in the function doc. This is not allowed. Thefunc_doc_language_specific_pre_processing
is not model-specific (on the other hand, functions likeconvert_to_tool
are model-specific); we perform it for all models regardless, you can think of it as part of the dataset transformation process (before we enter the model-specific format transformation phase)
Thanks for the explanation and sorry for the late reply and updates. |
We close this PR because we have updated the ToolACE handler to make it compatible with the latest BFCL in #653 . |
This PR adds the handler of the ToolACE model, which finetunes LLaMA-3.1-8B-Instruct model with ToolACE dataset, obtaining wonderful points in functional calling.
Here are the results on the latest (0824) version evaluated in our machine:
Thanks for your efforts in holding such a wonderful leaderboard. We need your help (@HuanzhiMao, @CharlieJCJ ) in adding our model to the leaderboard. Thanks a lot~