Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVOPS-5968/Add @gsganden as a code owner #167

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

gsganden
Copy link
Contributor

@gsganden gsganden commented Mar 23, 2022

Pull Request Process

Description

Adding myself as a codeowner so that I continue to receive notifications about contributions after I leave ShopRunner, a la ShopRunner/collie#45.

Checklist

General

  • Pull request uses keywords to close relevant issues.
  • Pull request includes unit tests for any bug fixes and new functionality.
  • Docs have been updated as needed. (sphinx-build docs docs/_html rebuilds the docs. Open docs/_html/index.html to check them.)

ShopRunner Contributors

The maintainer will complete the following steps for contributions from outside ShopRunner.

  • CHANGELOG.md has been updated. NA
  • _version.py has been updated. NA
  • Version number has been updated in docs/conf.py. NA

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #167 (50df7a4) into main (241c58f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   96.85%   96.85%           
=======================================
  Files          21       21           
  Lines         286      286           
=======================================
  Hits          277      277           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 241c58f...50df7a4. Read the comment docs.

@@ -1,4 +1,5 @@
git+https://github.com/crossnox/m2r@dev#egg=m2r # See https://github.com/sphinx-doc/sphinx/issues/7420
mistune<2 # See https://github.com/Azure/azure-sdk-for-python/issues/22019
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, needed for build to go through

@gsganden gsganden requested review from a team, mkatneni and harinireddy3 and removed request for a team March 23, 2022 21:22
@gsganden gsganden changed the title Add @gsganden as a code owner DEVOPS-5968 Add @gsganden as a code owner Mar 28, 2022
@gsganden gsganden changed the title DEVOPS-5968 Add @gsganden as a code owner DEVOPS-5968/Add @gsganden as a code owner Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant