[Fix] Skip UID update when in unsafe report mode #5171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
When we run
app info
on an app with an invalid extension TOML:WHAT is this pull request doing?
Skips the UID update when in unsafe report mode, as:
app info
anyway!How to test your changes?
shopify.extension.toml
fileshopify app info
twice.On the second time (on
main
), it will fail with a double UID error. But on this branch, if you start with a clean file, you can run it many times and not hit this issue.Measuring impact
How do we know this change was effective? Please choose one:
Checklist